Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialization Allocation changes #124

Closed
wants to merge 11 commits into from
Closed

Serialization Allocation changes #124

wants to merge 11 commits into from

Conversation

adamhathcock
Copy link
Member

No description provided.

@codecov Codecov
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 46.48023% with 555 lines in your changes missing coverage. Please review.

Project coverage is 44.19%. Comparing base (d73bf36) to head (284cf29).

Files with missing lines Patch % Lines
src/Speckle.Sdk/Helpers/SerializerIdWriter2.cs 14.00% 264 Missing ⚠️
...le.Sdk/Serialisation/SpeckleObjectDeserializer2.cs 0.00% 144 Missing and 1 partial ⚠️
...ckle.Sdk/Serialisation/SpeckleObjectSerializer2.cs 54.50% 103 Missing and 13 partials ⚠️
...nit/Serialisation/SerializerNonBreakingChanges2.cs 89.47% 14 Missing ⚠️
...k.Tests.Unit/Api/Operations/SerializationTests2.cs 95.31% 0 Missing and 6 partials ⚠️
...eckle.Sdk/Serialisation/Utilities/ClosureParser.cs 76.19% 5 Missing ⚠️
...peckle.Sdk/Helpers/SpeckleObjectSerializer2Pool.cs 75.00% 3 Missing ⚠️
src/Speckle.Sdk/Transports/ServerTransport.cs 0.00% 1 Missing ⚠️
...s/Speckle.Sdk.Serialization.Tests/TestTransport.cs 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##              dev     #124       +/-   ##
===========================================
+ Coverage   33.37%   44.19%   +10.81%     
===========================================
  Files         363      386       +23     
  Lines       11886    13494     +1608     
  Branches      972     1065       +93     
===========================================
+ Hits         3967     5963     +1996     
+ Misses       7710     7251      -459     
- Partials      209      280       +71

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamhathcock adamhathcock deleted the serialization-2 branch September 25, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adamhathcock